♻️ Merge discstore folder into jukebox#249
Merged
Merged
Conversation
Move all tests from tests/discstore/ to their new locations under tests/jukebox/, updating all imports from discstore.* to jukebox.* and from tests.discstore.* to tests.jukebox.*. Also fix test_di_container.py to patch the new jukebox module paths instead of the old discstore paths.
msgerbush
approved these changes
May 7, 2026
| from jukebox.domain.use_cases.library.resolve_tag_id import ResolveTagId | ||
| from jukebox.domain.use_cases.library.search_discs import SearchDiscs | ||
|
|
||
| LOGGER = logging.getLogger("discstore") |
Collaborator
There was a problem hiding this comment.
nit (non-blocking): we may want to change the logger name at some point
| from jukebox.domain.use_cases.library.list_discs import ListDiscs | ||
| from jukebox.domain.use_cases.library.remove_disc import RemoveDisc | ||
|
|
||
| LOGGER = logging.getLogger("discstore") |
Collaborator
There was a problem hiding this comment.
nit: change name here, too.
| def run(self) -> None: | ||
| print(self.help_message) | ||
| while True: | ||
| command = input("discstore> ") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discstore/code into thejukebox/package: entities, use cases, inbound adapters, CLI commands, DI container, and testsdiscstorepackage and remove it from build configTest plan
uv run pytest)discstoreimports remain in the codebasePart of #179